Spec HTTP client errors

[marandaneto]

Draft PR for this feature on Android - OkHttp getsentry/sentry-java#2287

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
develop	✅ Ready (Inspect)	Visit Preview	Oct 19, 2022 at 6:59AM (UTC)

[romtsn]

I noticed in the Android PR when dealing with headers you're also checking for sendDefaultPii + filtering out sensitive headers, should we mention it here in the spec as well? Otherwise LGTM, some minor wording things 👍

[marandaneto]

I noticed in the Android PR when dealing with headers you're also checking for sendDefaultPii + filtering out sensitive headers, should we mention it here in the spec as well? Otherwise LGTM, some minor wording things 👍

Nope, reason is here getsentry/sentry-java#2287
I just aligned the behavior with the Java repo, but other SDKs don't guard the headers with defaultPii.

[philipphofmann]

Thanks for writing down the spec and driving this new feature, @marandaneto. I have a couple of NITs and a few questions.

[philipphofmann]

One note about the range, apart from that great job @marandaneto 👏

[philipphofmann]

Sorry I completely forgot to ask: How should these errors be grouped together?

[marandaneto]

Sorry I completely forgot to ask: How should these errors be grouped together?

Stack trace normally, unless we see that this is not a good idea and can be improved later, but that's how Sentry works today, there's no special strategy unless you set fingerprints which can be done on eg beforeSend.

[philipphofmann]

Thanks, @marandaneto, for being patient with all my questions.