This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
feat: Add conventions for http.method and db.operation #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comment on lines
20
to
21
| | `http.request_content_length` | number | The encoded body size of the request. | `123` | | ||
| | `http.decoded_request_body_length` | number | The decoded body size of the request. | `456` | |
There was a problem hiding this comment.
Ah, I realized there's a mistake here that I merged in my last PR. I think we should be using response and not request
There was a problem hiding this comment.
you're right! I can update.
|
@narsaynorath I updated, and I also switched it from |
|
Merging since we're matching otel for the added attributes, and the rest is cleanup. |
narsaynorath
approved these changes
Apr 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need these new conventions for starfish work: getsentry/team-webplatform-meta#60
http.methoddb.operationhttp.transfer_sizetohttp.resource_transfer_size@k-fish I'm tagging to make sure that I'm not mucking up any performance detectors with my changes.