feat(devservices): Return namedtuple for docker compose command #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
- Coverage 92.48% 92.33% -0.16%
==========================================
Files 22 22
Lines 1344 1369 +25
==========================================
+ Hits 1243 1264 +21
- Misses 101 105 +4 ☔ View full report in Codecov by Sentry. |
IanWoodard
approved these changes
Dec 19, 2024
| @@ -14,7 +15,6 @@ | |||
| DEVSERVICES_DEPENDENCIES_CACHE_DIR_KEY = "DEVSERVICES_DEPENDENCIES_CACHE_DIR" | |||
| STATE_DB_FILE = os.path.join(DEVSERVICES_LOCAL_DIR, "state") | |||
| DEVSERVICES_ORCHESTRATOR_LABEL = "orchestrator=devservices" | |||
| DOCKER_COMPOSE_COMMAND_LENGTH = 7 | |||
There was a problem hiding this comment.
Thank goodness we can finally get rid of this 😌
devservices/constants.py
Outdated
Comment on lines
43
to
47
| class DockerComposeCommand(NamedTuple): | ||
| full_command: list[str] | ||
| project_name: str | ||
| config_path: str | ||
| services: list[str] |
There was a problem hiding this comment.
I'm not sure this belongs here. Shouldn't this live in docker_compose.py?
hubertdeng123
deleted the
hubertdeng123/use-namedtuple-docker-compose-command
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to determine the project name, services list, and config file path of each docker compose command. It removes hacky logic from up/down to obtain dependency names, and allows us to be more flexible in the future