Add Business hour logic to routing and triage #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hubertdeng123/add-holiday-exception
|
hmm flaky tests that are on main, I'll try to fix that up tomorrow |
chadwhitacre
reviewed
Dec 9, 2022
chadwhitacre
reviewed
Dec 9, 2022
hubertdeng123
commented
Dec 9, 2022
| @@ -182,10 +182,9 @@ describe('issueNotifier Tests', function () { | |||
| expect(say).lastCalledWith( | |||
| 'This channel is set to receive notifications for: Team: Test (no office specified)' | |||
| ); | |||
| expect(await getLabelsTable().where({ channel_id })).toEqual([ | |||
| expect(await getLabelsTable().where({ channel_id })).toMatchObject([ | |||
There was a problem hiding this comment.
this fixes flaky tests, id here isn't what we care about
5 tasks
chadwhitacre
approved these changes
Dec 9, 2022
emmatyping
reviewed
Dec 12, 2022
emmatyping
reviewed
Dec 12, 2022
emmatyping
approved these changes
Dec 12, 2022
chadwhitacre
requested changes
Dec 12, 2022
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two functions allows for calculating
timeToTriageByandtimeToRouteByin business hours instead of business days.