Abstract Waiting for: * automations from rerouting
#480
Conversation
hubertdeng123
changed the title
Waiting for: * automations from triaging
| @@ -48,7 +48,7 @@ export async function addIssueToGlobalIssuesProject( | |||
|
|
|||
| const response: any = await octokit.graphql(addIssueToGlobalIssuesProjectMutation); | |||
|
|
|||
| return response.addProjectV2ItemById.item.id; | |||
| return response?.addProjectV2ItemById.item.id; | |||
There was a problem hiding this comment.
| @@ -113,15 +111,6 @@ export async function markUnrouted({ | |||
| body: `Assigning to @${SENTRY_ORG}/support for [routing](https://open.sentry.io/triage/#2-route), due by **<time datetime=${timeToRouteBy}>${readableDueByDate}</time> (${lastOfficeInBusinessHours})**. ⏲️`, | |||
| }); | |||
|
|
|||
| const itemId: string = await addIssueToGlobalIssuesProject(payload.issue.node_id, repo, issueNumber, octokit); | |||
There was a problem hiding this comment.
This is duplicate logic, since when Waiting for: Support is added, there is automation that kicks in in followups.ts that handles this. I have a feeling that's where this error is coming from:
https://sentry.sentry.io/issues/4239815892/?project=5246761&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=24h&stream_index=3&utc=true
hubertdeng123
changed the title
Waiting for: * automations from triagingWaiting for: * automations from rerouting
src/brain/issueLabelHandler/route.ts
Outdated
| }); | ||
|
|
||
| // Only retriage issues if support is routing | ||
| if (labelNames.includes(WAITING_FOR_SUPPORT_LABEL)) { |
There was a problem hiding this comment.
What do you think about this, Waiting for: * label only changes is support is doing the routing?
There was a problem hiding this comment.
I like it! This way if some other EPD member at Sentry updates the product area then it will not automatically go to triage, but we can assume Support does mean to retriage. 👍
P.S. If you want to use the other suggestion above, then also this:
| if (labelNames.includes(WAITING_FOR_SUPPORT_LABEL)) { | |
| if (isBeingRoutedBySupport) { |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
=======================================
Coverage 82.73% 82.74%
=======================================
Files 96 96
Lines 2485 2486 +1
Branches 478 480 +2
=======================================
+ Hits 2056 2057 +1
Misses 423 423
Partials 6 6
☔ View full report in Codecov by Sentry. |
| @@ -192,11 +181,12 @@ export async function markRouted({ | |||
| const owner = payload.repository.owner.login; | |||
| const octokit = await getClient(ClientType.App, owner); | |||
| const labelsToRemove: string[] = []; | |||
| const labelNames = issue?.labels?.map(label => label.name) || []; | |||
There was a problem hiding this comment.
How about moving this up here?
| const labelNames = issue?.labels?.map(label => label.name) || []; | |
| const isBeingRoutedBySupport = labelNames.includes(WAITING_FOR_SUPPORT_LABEL); |
hubertdeng123
force-pushed
the
hubertdeng123/separate-out-waiting-for-and-triaging
branch
from
a5f16bb
to
f463269
Compare
hubertdeng123
force-pushed
the
hubertdeng123/separate-out-waiting-for-and-triaging
branch
from
f463269
to
24ad822
Compare
hubertdeng123
deleted the
hubertdeng123/separate-out-waiting-for-and-triaging
branch
With this change, triaging issues won't happen when issues are routed to new product area unless the issue is
Waiting for: Support.