Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache the whole client #489

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Cache the whole client #489

merged 1 commit into from
Jun 20, 2023

Conversation

chadwhitacre
Copy link
Member

We've had this comment forever:

Not sure if we can cache the octokit instance - installation tokens expire
after an hour, but octokit client may be able to handle this properly.

I found docs that say the octokit client does handle this properly!

This is preparatory to adding support for configuring more than one client to support multi-org for #482.

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (4de769c) 82.74% compared to head (8efab1c) 82.71%.

❗ Current head 8efab1c differs from pull request most recent head 692886b. Consider uploading reports for the commit 692886b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   82.74%   82.71%   -0.04%     
==========================================
  Files          96       96              
  Lines        2486     2487       +1     
  Branches      479      479              
==========================================
  Hits         2057     2057              
- Misses        423      424       +1     
  Partials        6        6              
Impacted Files Coverage Δ
src/api/github/getClient.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chadwhitacre chadwhitacre mentioned this pull request Jun 16, 2023
43 tasks
Copy link
Member

@hubertdeng123 hubertdeng123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!🚀

@chadwhitacre chadwhitacre merged commit 63830ae into main Jun 20, 2023
@chadwhitacre chadwhitacre deleted the cwlw/cache-clients branch June 20, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants