Factor auth out of _getAppClient #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
chadwhitacre
force-pushed
the
cwlw/factor-out-retries
branch
from
0a98ae3
to
383b4e7
Compare
chadwhitacre
force-pushed
the
cwlw/factor-out-auth
branch
from
75f0c77
to
406331a
Compare
hubertdeng123
approved these changes
Jun 20, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
=======================================
Coverage 82.74% 82.74%
=======================================
Files 96 96
Lines 2486 2486
Branches 479 478 -1
=======================================
Hits 2057 2057
Misses 423 423
Partials 6 6
☔ View full report in Codecov by Sentry. |
hubertdeng123
requested changes
Jun 20, 2023
chadwhitacre
commented
Jun 20, 2023
|
|
||
| // Use the unbound client to hydrate a client bound to an org. | ||
| const installation = await appClient.apps.getOrgInstallation({ org }); | ||
| client = _getAppClient(installation.data.id); | ||
| auth.installationId = installation.data.id; |
There was a problem hiding this comment.
I logged locally and also browsed GitHub's UI for existing apps, this does appear to be numeric (per the type def above).
hubertdeng123
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #490.
This sets us up to make app auth variable in the org requested.