Use Waiting for: Product Owner label to send triage notifications
#492
Conversation
hubertdeng123
changed the base branch from
main
to
hubertdeng123/save-due-by-dates-for-issues-in-project
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
==========================================
+ Coverage 83.07% 83.37% +0.29%
==========================================
Files 96 96
Lines 2523 2520 -3
Branches 493 490 -3
==========================================
+ Hits 2096 2101 +5
+ Misses 421 412 -9
- Partials 6 7 +1
☔ View full report in Codecov by Sentry. |
…d timestamp isn't there
hubertdeng123
force-pushed
the
hubertdeng123/use-waiting-for-labels-triage-notifications
branch
from
e214f71
to
b865b19
Compare
hubertdeng123
force-pushed
the
hubertdeng123/save-due-by-dates-for-issues-in-project
branch
from
d8690e3
to
16e8174
Compare
src/utils/githubEventHelpers.ts
Outdated
| node(id: "${issueNodeId}") { | ||
| ... on ProjectV2Item { | ||
| id | ||
| fieldValueByName(name: "Respond By") { |
There was a problem hiding this comment.
Do we have to query by name? If we query by id then it would be immutable, maybe?
There was a problem hiding this comment.
I guess I like having the flexibility to tinker with the names of the project board and fields without messing up the automation, if possible.
There was a problem hiding this comment.
I also do like that, but I don't think it's possible. Played around with this using the GH graphql explorer and it's only allowing me to input a field value by name
There was a problem hiding this comment.
Do you think it's worth it to use fieldValues and iterate over all of them to find the value by id? Less efficient but more resilient. I've already changed the name of the field in prod, happened days/weeks ago. 🐭
There was a problem hiding this comment.
This is what using fieldValues looks like
const query = `query{
node(id: "${issueNodeId}") {
... on ProjectV2Item {
id
fieldValues(first: 50) {
nodes {
... on ProjectV2ItemFieldTextValue {
id
text
field {
... on ProjectV2Field {
id
name
}
}
}
}
}
}
}
}`;
const data = {
issueNodeId,
};
const response = await sendQuery(query, data, octokit);
// When the response due date is empty, the node doesn't exist so we default to empty string
const issueDueDateInfoNode = response?.node.fieldValues.nodes.find(item => item.field?.id === RESPONSE_DUE_DATE_FIELD_ID) || "";
return issueDueDateInfoNode.text;
Honestly, I really don't like relying on this line here...
const issueDueDateInfoNode = response?.node.fieldValues.nodes.find(item => item.field?.id === RESPONSE_DUE_DATE_FIELD_ID) || "";```
Thoughts?
There was a problem hiding this comment.
not all items on the project board have the same fields
Say more about this? Surprises me if true.
There was a problem hiding this comment.
Say more about this? Surprises me if true.
Er, I meant to say number of fieldValues. Say there are 6 fields for an item on a project board. If the due date field is an empty string, GH graphql api returns 5 nodes in the fieldValues.
There was a problem hiding this comment.
Ah, gotcha. Yeah, that's weird. :-/
There was a problem hiding this comment.
Implemented the changes above. @chadwhitacre are there any other concerns for this to go in?
There was a problem hiding this comment.
Let's add a comment explaining why we're using fieldValues then I'm good to go. 👍
Co-authored-by: Chad Whitacre <chadwhitacre@sentry.io>
hubertdeng123
deleted the
hubertdeng123/use-waiting-for-labels-triage-notifications
branch
Uses
Waiting for: Product Ownerinstead ofStatus: Untriagedto send slack notifications