Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of unrouted and untriaged labels #517

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

hubertdeng123
Copy link
Member

👋

@hubertdeng123 hubertdeng123 requested a review from a team July 10, 2023 22:55
Copy link
Member

@chadwhitacre chadwhitacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to do a fine job of search/replacing Status for Waiting for labels. I think there's some deeper refactoring that could go along with this, but no need to block on that here.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06 ⚠️

Comparison is base (0b2a35b) 84.50% compared to head (a39eb13) 84.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
- Coverage   84.50%   84.45%   -0.06%     
==========================================
  Files          96       96              
  Lines        2479     2471       -8     
  Branches      481      473       -8     
==========================================
- Hits         2095     2087       -8     
  Misses        377      377              
  Partials        7        7              
Impacted Files Coverage Δ
src/config/index.ts 98.01% <ø> (-0.04%) ⬇️
src/brain/issueLabelHandler/followups.ts 100.00% <100.00%> (ø)
src/brain/issueLabelHandler/index.ts 100.00% <100.00%> (ø)
src/brain/issueLabelHandler/route.ts 97.29% <100.00%> (-0.08%) ⬇️
src/brain/issueLabelHandler/triage.ts 97.77% <100.00%> (+0.05%) ⬆️
src/brain/issueNotifier/index.ts 77.41% <100.00%> (+0.24%) ⬆️
src/utils/businessHours.ts 98.98% <100.00%> (-0.06%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hubertdeng123 hubertdeng123 merged commit 502537e into main Jul 11, 2023
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/remove-unrouted-untriaged-labels branch July 11, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants