-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start teaching the app loader about envvar numbers #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
==========================================
+ Coverage 84.53% 84.65% +0.12%
==========================================
Files 97 97
Lines 2476 2509 +33
Branches 474 476 +2
==========================================
+ Hits 2093 2124 +31
- Misses 376 378 +2
Partials 7 7
☔ View full report in Codecov by Sentry. |
chadwhitacre
commented
Jul 13, 2023
chadwhitacre
commented
Jul 13, 2023
chadwhitacre
commented
Jul 13, 2023
chadwhitacre
commented
Jul 13, 2023
6 tasks
Co-authored-by: Hubert Deng <hubert.deng@sentry.io>
azaslavsky
reviewed
Jul 13, 2023
hubertdeng123
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #482, before #524.
We need two passes to parsing, one where we collect configs based on the number in envvars of the form
GH_APP_1_FOO
, and then another where we organize apps by org slug. This PR stubs out this two-pass structure without yet switching to the new envvars.