Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start teaching the app loader about envvar numbers #523

Merged
merged 9 commits into from
Jul 13, 2023

Conversation

chadwhitacre
Copy link
Member

@chadwhitacre chadwhitacre commented Jul 13, 2023

Part of #482, before #524.

We need two passes to parsing, one where we collect configs based on the number in envvars of the form GH_APP_1_FOO, and then another where we organize apps by org slug. This PR stubs out this two-pass structure without yet switching to the new envvars.

@chadwhitacre chadwhitacre mentioned this pull request Jul 13, 2023
43 tasks
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 95.50% and project coverage change: +0.12 🎉

Comparison is base (3236a12) 84.53% compared to head (ac64786) 84.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
+ Coverage   84.53%   84.65%   +0.12%     
==========================================
  Files          97       97              
  Lines        2476     2509      +33     
  Branches      474      476       +2     
==========================================
+ Hits         2093     2124      +31     
- Misses        376      378       +2     
  Partials        7        7              
Impacted Files Coverage Δ
src/webhooks/pubsub/slackNotifications.ts 71.61% <ø> (ø)
src/webhooks/pubsub/index.ts 37.50% <33.33%> (-1.64%) ⬇️
src/config/loadGitHubAppsFromEnvironment.ts 95.12% <94.87%> (-4.88%) ⬇️
src/api/github/getClient.ts 89.28% <100.00%> (+2.61%) ⬆️
src/brain/issueLabelHandler/followups.ts 100.00% <100.00%> (ø)
src/brain/issueLabelHandler/route.ts 97.36% <100.00%> (+0.07%) ⬆️
src/brain/issueLabelHandler/triage.ts 97.82% <100.00%> (+0.04%) ⬆️
src/brain/projectsHandler/project.ts 97.43% <100.00%> (+0.06%) ⬆️
src/config/index.ts 97.82% <100.00%> (-0.18%) ⬇️
src/utils/githubEventHelpers.ts 89.23% <100.00%> (-0.17%) ⬇️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chadwhitacre chadwhitacre mentioned this pull request Jul 13, 2023
6 tasks
Co-authored-by: Hubert Deng <hubert.deng@sentry.io>
@chadwhitacre chadwhitacre merged commit d8a18c6 into main Jul 13, 2023
@chadwhitacre chadwhitacre deleted the cwlw/refactor-for-numbers branch July 13, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants