Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Waiting for: Product Owner across all issues where a community member comments #527

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

hubertdeng123
Copy link
Member

see title

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (5d26a17) 84.65% compared to head (401019a) 84.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
- Coverage   84.65%   84.64%   -0.02%     
==========================================
  Files          97       97              
  Lines        2509     2507       -2     
  Branches      476      476              
==========================================
- Hits         2124     2122       -2     
  Misses        378      378              
  Partials        7        7              
Impacted Files Coverage Δ
src/brain/issueLabelHandler/followups.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hubertdeng123 hubertdeng123 changed the title Add Waiting for: Product Owner across all issues/PR's where a community member comments Add Waiting for: Product Owner across all issues where a community member comments Jul 19, 2023
@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Jul 19, 2023

This should not include PR's. Maybe in the future, but there are some gaps right now that need to be addressed before that happens. Example, PR's do not have Product Areas, so slack notifications will break.

@hubertdeng123 hubertdeng123 requested a review from a team July 19, 2023 23:25
@hubertdeng123
Copy link
Member Author

This may be annoying when a product owner removes the Waiting for: Product Owner label and wants the item backlogged. Then multiple people comment on the issue and automation adds back Waiting for: Product Owner. 🤔

@hubertdeng123 hubertdeng123 merged commit 317740a into main Jul 21, 2023
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/enable-followups-all-issues branch July 21, 2023 20:30
@chadwhitacre
Copy link
Member

This may be annoying when a product owner removes the Waiting for: Product Owner label and wants the item backlogged. Then multiple people comment on the issue and automation adds back Waiting for: Product Owner. 🤔

Ftr we had a conversation about this and decided to proceed as-is for now. If there's an active conversation going on (like every few minutes back and forth) the product owner can leave "Waiting for" on there until the conversation dies down. What happens when a user comments and "Waiting for: Product Owner" is already applied? That's a no-op, correct?

@hubertdeng123
Copy link
Member Author

What happens when a user comments and "Waiting for: Product Owner" is already applied? That's a no-op, correct?

Correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants