Factor isNotFromAnExternalOrGTMUser out of githubEventHelpers #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadwhitacre
commented
Jul 21, 2023
| modifyDueByDate, | ||
| modifyProjectIssueField, | ||
| shouldSkip, | ||
| } from '@utils/githubEventHelpers'; | ||
| import { isFromABot } from '@utils/isFromABot'; | ||
| import { isNotFromAnExternalOrGTMUser } from '@utils/isNotFromAnExternalOrGTMUser'; |
There was a problem hiding this comment.
Note parallel with isFromABot on the previous line.
This was referenced Jul 21, 2023
hubertdeng123
approved these changes
Jul 21, 2023
chadwhitacre
force-pushed
the
cwlw/factor-out-org
branch
2 times, most recently
from
aa44c03 to
17e4d89
Compare
chadwhitacre
force-pushed
the
cwlw/isnotfromablahblah
branch
from
95b1369 to
55ab3d8
Compare
Boring. :P |
chadwhitacre
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
==========================================
+ Coverage 84.61% 84.63% +0.01%
==========================================
Files 98 99 +1
Lines 2503 2505 +2
Branches 476 476
==========================================
+ Hits 2118 2120 +2
Misses 378 378
Partials 7 7
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #482, after #532.
I want to see if I can put the GraphQL wrappers on GitHubOrg. Gotta get this helper out of the way first.