Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move helpers to GitHubOrg #539

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Move helpers to GitHubOrg #539

merged 1 commit into from
Jul 25, 2023

Conversation

chadwhitacre
Copy link
Member

@chadwhitacre chadwhitacre commented Jul 23, 2023

Part of #482, after #538.

This moves the rest of the helper functions to GitHubOrg methods, for better encapsulation.

@@ -57,4 +57,210 @@ export class GitHubOrg {
}
return response;
}

async addIssueToGlobalIssuesProject(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Base automatically changed from cwlw/send-graph-query to main July 25, 2023 11:27
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 96.36% and project coverage change: +0.08% 🎉

Comparison is base (a399674) 84.65% compared to head (a1f6699) 84.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   84.65%   84.73%   +0.08%     
==========================================
  Files         100       99       -1     
  Lines        2515     2502      -13     
  Branches      481      481              
==========================================
- Hits         2129     2120       -9     
+ Misses        379      375       -4     
  Partials        7        7              
Files Changed Coverage Δ
src/api/github/org.ts 93.54% <95.23%> (+3.54%) ⬆️
src/brain/issueLabelHandler/followups.ts 100.00% <100.00%> (ø)
src/brain/issueLabelHandler/route.ts 97.36% <100.00%> (-0.04%) ⬇️
src/brain/issueLabelHandler/triage.ts 100.00% <100.00%> (+2.17%) ⬆️
src/brain/projectsHandler/project.ts 97.36% <100.00%> (-0.07%) ⬇️
src/webhooks/pubsub/slackNotifications.ts 71.42% <100.00%> (-0.19%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chadwhitacre chadwhitacre merged commit 02dbb4c into main Jul 25, 2023
@chadwhitacre chadwhitacre deleted the cwlw/move-helpers branch July 25, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants