-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear issue status on label removal from user #560
Clear issue status on label removal from user #560
Conversation
@@ -4,11 +4,11 @@ getsentry: | |||
privateKey: 'STUB' | |||
installationId: -1 | |||
project: | |||
nodeId: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes assertions more accurate in tests to populate these with values
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
==========================================
- Coverage 85.22% 85.05% -0.17%
==========================================
Files 99 99
Lines 2457 2483 +26
Branches 481 484 +3
==========================================
+ Hits 2094 2112 +18
- Misses 357 365 +8
Partials 6 6
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, with minor comments.
payload, | ||
...rest | ||
}: EmitterWebhookEvent<'issues.unlabeled'>) { | ||
const tx = Sentry.startTransaction({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eating our own 🐶 🥫 , nice!
When a user removes a
Waiting for: *
label from an issue, clear status inIssues Someone Else Cares About
board. If it's a bot, don't clear, since the bot will only unlabel issues when it is about to add another one.