Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear issue status on label removal from user #560

Merged

Conversation

hubertdeng123
Copy link
Member

When a user removes a Waiting for: * label from an issue, clear status in Issues Someone Else Cares About board. If it's a bot, don't clear, since the bot will only unlabel issues when it is about to add another one.

@hubertdeng123 hubertdeng123 requested a review from a team July 27, 2023 22:38
@@ -4,11 +4,11 @@ getsentry:
privateKey: 'STUB'
installationId: -1
project:
nodeId: ''
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes assertions more accurate in tests to populate these with values

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 69.23% and project coverage change: -0.17% ⚠️

Comparison is base (bd3931c) 85.22% compared to head (b743b64) 85.05%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   85.22%   85.05%   -0.17%     
==========================================
  Files          99       99              
  Lines        2457     2483      +26     
  Branches      481      484       +3     
==========================================
+ Hits         2094     2112      +18     
- Misses        357      365       +8     
  Partials        6        6              
Files Changed Coverage Δ
src/api/github/org.ts 87.14% <0.00%> (-5.29%) ⬇️
src/brain/issueLabelHandler/followups.ts 95.18% <80.00%> (-4.82%) ⬇️
src/brain/issueLabelHandler/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@azaslavsky azaslavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with minor comments.

src/brain/issueLabelHandler/followups.ts Show resolved Hide resolved
src/brain/issueLabelHandler/index.test.ts Outdated Show resolved Hide resolved
payload,
...rest
}: EmitterWebhookEvent<'issues.unlabeled'>) {
const tx = Sentry.startTransaction({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eating our own 🐶 🥫 , nice!

@hubertdeng123 hubertdeng123 enabled auto-merge (squash) July 28, 2023 23:13
@hubertdeng123 hubertdeng123 merged commit 2cb4d38 into main Jul 28, 2023
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/clear-issue-status-on-user-label-removal branch July 28, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants