test: fix CI test failures after 2.14.0 release #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix update-dependency.Tests.ps1 to use same version sorting logic as actual script - Update workflow-args.sh to dynamically return latest tag using git describe - Ensures CI tests remain stable across releases without manual updates 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
vaind
changed the title
- Remove git describe fallback complexity - Always use git ls-remote for consistency with PowerShell script - More reliable in CI environments and shallow clones
- Test now expects actual version number instead of hardcoded 'latest' - Verifies originalTag == latestTag to ensure no update is needed - Maintains expectation of empty outputs when no update occurs
- Test now accepts either 'latest' or actual version number format - Maintains backward compatibility while supporting dynamic versioning - Still ensures originalTag == latestTag for no-update scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
updater/tests/update-dependency.Tests.ps1git ls-remote --sortto using the same version sorting logic as the actualupdate-dependency.ps1scriptupdater/tests/workflow-args.shgit describe --tags --abbrev=0Test plan
update-dependency.ps1shows no update needed for workflow-args.sh (originalTag=latestTag=2.14.0)Root Cause
After the 2.14.0 release, the test scripts were still expecting "latest" while the updater found a newer version (2.14.0), causing the workflow to set outputs when the tests expected them to be empty.
🤖 Generated with Claude Code