Skip to content

Conversation

@vaind
Copy link
Contributor

@vaind vaind commented Sep 22, 2025

Summary

Fixes the Craft release failure by removing automatic workflow file updates that require GitHub App workflows permission.

Problem

The Craft release process failed with this error:

refusing to allow a GitHub App to create or update workflow `.github/workflows/danger.yml` without `workflows` permission

This happened because our PowerShell script tried to automatically update _workflow_version defaults in workflow files during the release, but GitHub Apps don't have workflows permission by default.

Solution

  • Removes automatic workflow file updates from the PowerShell script
  • Provides clear manual instructions for updating _workflow_version defaults after release
  • Maintains the script structure for potential future use with proper permissions

Changes

  • Modified scripts/update-version.ps1 to only display instructions instead of modifying workflow files
  • Script now outputs clear manual action required message
  • Prevents Craft release failures due to insufficient permissions

Manual Process

After each release is published, manually update:

  • .github/workflows/updater.yml (line ~45)
  • .github/workflows/danger.yml (line ~9)

Change the default value from the old version to the new version.

Test plan

  • Test script runs without errors
  • Verify script provides clear instructions
  • Test Craft release process completes successfully

🤖 Generated with Claude Code

GitHub Apps cannot modify workflow files without 'workflows' permission,
causing Craft releases to fail when trying to update _workflow_version
defaults. The script now provides manual instructions instead.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Fixes

- Remove workflow file updates from Craft release automation ([#112](https://github.com/getsentry/github-workflows/pull/112))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against a4ae257

@vaind
Copy link
Contributor Author

vaind commented Sep 22, 2025

replaced by #112

@vaind vaind closed this Sep 22, 2025
@vaind vaind deleted the fix/craft-workflows-permission branch September 22, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants