Skip to content

fix: accept chunked ProGuard uploads #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpnurmi wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −1
Open

fix: accept chunked ProGuard uploads #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f858bc
fix: accept chunked proguard uploads
jpnurmi Jan 9, 2026
4b46a24
Add test for relevant caps in chunk-upload response
jpnurmi Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
### Fixes

- Sentry-CLI integration test action - Replace literal "\n" with newlines ([#138](https://github.com/getsentry/github-workflows/pull/138))
- Sentry-CLI integration test action - Accept chunked ProGuard uploads for compatibility with Sentry CLI 3.x ([#140](https://github.com/getsentry/github-workflows/pull/140))

## 3.1.0

Expand Down
2 changes: 1 addition & 1 deletion sentry-cli/integration-test/sentry-server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def do_GET(self):
self.writeJSON('{"url":"' + uri.geturl() + self.path + '",'
'"chunkSize":8388608,"chunksPerRequest":64,"maxFileSize":2147483648,'
'"maxRequestSize":33554432,"concurrency":1,"hashAlgorithm":"sha1","compression":["gzip"],'
'"accept":["debug_files","release_files","pdbs","sources","bcsymbolmaps","il2cpp","portablepdbs"]}')
'"accept":["debug_files","release_files","pdbs","sources","bcsymbolmaps","il2cpp","portablepdbs","proguard"]}')
elif self.isApi('/api/0/organizations/{}/repos/?cursor='.format(apiOrg)):
self.writeJSONFile("assets/repos.json")
elif self.isApi('/api/0/organizations/{}/releases/{}@{}/previous-with-commits/'.format(apiOrg, appIdentifier, version)):
Expand Down
12 changes: 12 additions & 0 deletions sentry-cli/integration-test/tests/action.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,18 @@ Describe 'Invoke-SentryServer' {
$result.UploadedDebugFiles() | Should -Be @('file3.dylib', 'file2.so', 'file1.dll')
}

It "accepts chunked uploads" {
$result = Invoke-SentryServer {
param([string]$url)
$response = Invoke-WebRequest -Uri "$url/api/0/organizations/org/chunk-upload/"
$json = $response.Content | ConvertFrom-Json
@("debug_files", "pdbs", "sources", "portablepdbs", "proguard") | ForEach-Object {
$json.accept | Should -Contain $_
}
}
Should -ActualValue $result.HasErrors() -BeFalse
}

It "collects proguard mapping" {
$result = Invoke-SentryServer {
Param([string]$url)
Expand Down
Loading