Minor insight tweak & cleanups #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-e
approved these changes
Jun 20, 2025
src/launchpad/insights/insight.py
Outdated
| All data needed for the insight must be collected during the main analysis phase. | ||
| """ | ||
|
|
||
| def get_results(self, input: InsightsInput) -> T_co: |
There was a problem hiding this comment.
nit: could this be something like perform() to indicate that work is being done, get kind of hides that.
There was a problem hiding this comment.
e.g. when I implement the image compression insight that becomes more apparent
There was a problem hiding this comment.
Yep, will update to something along those lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was reviewing #51 and realized the
__call__notation felt awkward (did some reading on it). If anything, IMO we should remove__call__and replace with an invocation of the instance (DuplicateFilesInsight()(insights_input)), which feels even more awkward.Instead I renamed it to
get_resultsto make this a bit more understandable without Python callable context IMO and moved base models outside ofcommon.pyand removed some Cursor gen'd docs