Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable warning ndk build #9

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Conversation

supervacuus
Copy link
Collaborator

@supervacuus supervacuus commented Nov 20, 2024

fixes getsentry/sentry-native#1085

In addition to ignoring the irrelevant warning, I also took the liberty to fix the GHA workflow:

  • I increased the supported range to Android 35 and ndk 27 because that is what we should support downstream
  • switched to Ubuntu from macOS because it is more available and typically runs faster (always use Ubuntu runners instead of macOS if that is an option)
  • updated all action versions to a recent version
  • using setup-java and setup-android actions so we can have a stable pre-config setup vs. relying on what the runner-image provides (which broke the initial run)
  • switch to use sdkmanager from thecmdline-tools path because that is what the modern SDK path looks like
  • adding additional ABI builds because we need to support them downstream

@supervacuus supervacuus requested a review from markushi November 20, 2024 15:27
Copy link
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@supervacuus supervacuus merged commit 284202f into master Nov 21, 2024
3 checks passed
@supervacuus supervacuus deleted the fix/disable_warning_ndk_build branch November 21, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Warnings when compiling ndk/sentry-native support
2 participants