This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
fix: cleanup timer and reuse exports #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasBa
commented
Jan 8, 2024
| } | ||
|
|
||
| napi_value external; | ||
| if (napi_create_external(env, profiler, nullptr, nullptr, &external) != |
There was a problem hiding this comment.
this was unnecessary since NAPI_INIT provides the exports napi_value already
anonrig
reviewed
Jan 8, 2024
|
Somehow, we have a lint issue, but GitHub workflow doesn't give us a warning? |
|
I'm going to check, it should be failing, but I also noticed some formatting changes were applied that shouldn't be |
|
@anonrig let me fix the linter separately, I want to merge this so we fix the issue and unblock the user. I'll followup with the linter change |
anonrig
approved these changes
Jan 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #228 (tested by linking the built module to the reproducible code from issue).