Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Commit

Permalink
Remove memwatch-next from deps to make CI pass, add manual mem test r…
Browse files Browse the repository at this point in the history
…unning instructions
  • Loading branch information
LewisJEllis committed Apr 6, 2017
1 parent 161790e commit 6cbdb32
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
"glob": "~3.1.13",
"istanbul": "^0.4.3",
"koa": "*",
"memwatch-next": "^0.3.0",
"mocha": "~3.1.2",
"nock": "~9.0.0",
"should": "11.2.0"
Expand Down
8 changes: 8 additions & 0 deletions test/manual/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@ We also have a `/gc` endpoint for forcing a garbage collection; this is used at

Note: there's a `/capture` endpoint which does a basic `captureException` call 1000 times. That's our current problem child requiring some more investigation on its memory usage.

## How to run it
```bash
npm install memwatch-next
node manager.js
# in another tab send some traffic at it:
curl localhost:3000/capture
```

## Why this can't be more automated
Some objects can have long lifecycles or not be cleaned up by GC when you think they would be, and so it isn't straightforward to make the assertion "memory usage should have returned to baseline by now". Also, when the numbers look bad, it's pretty obvious to a trained eye that they're bad, but it can be hard to quantify an exact threshold of pass or fail.

Expand Down

0 comments on commit 6cbdb32

Please sign in to comment.