Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Swap out for deprecated hostname #101

Merged
merged 4 commits into from
Apr 16, 2015
Merged

Conversation

connor4312
Copy link
Contributor

Fixes #96

@mattrobenolt
Copy link
Contributor

So according to this:

https://github.com/strongloop/express/blob/master/lib/request.js#L391-L395

It sounds like we'd want to check for req.hostname before req.host if the value of req.host is going to change. Then older versions of Express will fall back from req.hostname to req.host just fine.

@connor4312
Copy link
Contributor Author

Adjusted :)

@YarivGilad
Copy link

"express deprecated req.host: Use req.hostname instead ... node_modules/raven/lib/parsers.js:84:19
very easy to fix - I swapped it locally but every time I install the package it throws this error again - please change it. simply replace req.host with req.hostname like the error message suggests.
Thanks
Ajar

@gigablah
Copy link

+1. Would love to see this merged.

@mattrobenolt
Copy link
Contributor

derp, this fell under my radar. Sorry about that!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Express deprecation warning for req.host
4 participants