This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Make capture* callbacks fire after sending, more API cleanup/singletonization #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short version: addresses #213, moves the API to follow raven-js almost exactly, still maintains BC in almost all ways with old API
Details:
The only public API usage affected by this should be the one described by @mattrobenolt in #213, and the realistic caveat to run into from it is that existing code looking at
eventId
s fromcapture*
callbacks will now getnull
instead of a string./cc @benvinegar