Cleaning up wrap, adding intercept

[LewisJEllis]

This is a little WIPpy, need to test more, but I realized 1) usefulness of an intercept function and 2) some simplifications to wrap.

[LewisJEllis]

@benvinegar or @MaxBittker take a look?

Main consideration - is intercept the right name for this; was originally inspired by domain.intercept but this isn't really using domains, just an errback pattern; also thinking about interceptErr or wrapErr or something.

Usage pattern is:

doSomethingThatTakesCallback(Raven.intercept(function (err, result) {
  // err will never be instanceof Error; if it was, intercept caught it, reported, didn't call this cb
  // can proceed without patterns like below:
  if (err) return next(err);
  if (err) return Raven.captureException(err);
});

Another consideration - callback could really just be function (result) since we know err will never be passed, but I think we should keep the same signature so this can just be used as a wrapper around callbacks that already expect the function (err, callback) pattern.

[MaxBittker]

re: naming, the special thing about this intercept function is that it works with the node err callback argument convention, vs the exception world (which doesn't work with async callbacks). That being said, would a name that references this is specifically for callback errs be more descriptive?

[MaxBittker]

the code lgtm

[MaxBittker]

intercept looks good to me, wrapdomain change seems to make sense 👍

[MaxBittker]

lgtm