This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Pass kwargs into shouldSendCallback() as param #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LewisJEllis
approved these changes
Jan 9, 2017
|
Whoops, good catch, thanks! |
|
Awesome. Can you publish a new version of the library to npm? |
|
@jeffwhelpley published in 1.1.2, sorry for the delay! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
shouldSendCallbackfunction, we need the args in order to determine whether we want to send to sentry based on the current data. This is exactly how things work for the JavaScript client version of raven.