This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Version 2.0.0 #314
Merged
Version 2.0.0 #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on our previous discussion, this seems right, but I think I'll leave to @MaxBittker to approve. |
MaxBittker
reviewed
May 11, 2017
History.md
Outdated
| @@ -1,3 +1,16 @@ | |||
| # 2.0.0 - 5/10/2017 | |||
| - Properly surface errors to preserve process exit conditions [See #308, #257] | |||
| - Node processes with raven will now exit in *all* the same situations as if raven were not present | |||
There was a problem hiding this comment.
maybe don't emphasize all here when it's not a hard hard guarantee
There was a problem hiding this comment.
just say "the same situations" imo
MaxBittker
approved these changes
May 11, 2017
LewisJEllis
force-pushed
the
release-2.0.0
branch
from
31c1fa3 to
5596e1d
Compare
LewisJEllis
force-pushed
the
release-2.0.0
branch
from
5596e1d to
458e329
Compare
Mostly just the one point about shutdown conditions; added a bold callout. Added the postgres autobreadcrumb removal to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepting feedback on the release notes. Will publish first thing tomorrow.
/cc @MaxBittker @benvinegar