Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

feat: Fall back to NODE_ENV for Sentry Environment #384

Merged
merged 1 commit into from
Sep 27, 2017
Merged

feat: Fall back to NODE_ENV for Sentry Environment #384

merged 1 commit into from
Sep 27, 2017

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek requested review from a team and removed request for benvinegar September 26, 2017 15:38
benvinegar
benvinegar reviewed Sep 27, 2017
View reviewed changes
docs/config.rst Outdated
@@ -241,4 +241,4 @@ Environment Variables

.. describe:: SENTRY_ENVIRONMENT

Optionally set the environment name, e.g. "staging", "production".
Optionally set the environment name, e.g. "staging", "production". You can also use `NODE_ENV` variable instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably change this to say, "Sentry will default to the value of NODE_ENV, if present."

@kamilogorek kamilogorek merged commit 9219b55 into master Sep 27, 2017
@kamilogorek kamilogorek deleted the node-env branch September 27, 2017 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benvinegar benvinegar benvinegar left review comments

@mitsuhiko mitsuhiko mitsuhiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamilogorek @benvinegar @mitsuhiko