This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
feat: Sensible non-Error exception serializer #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvinegar
reviewed
Jan 11, 2018
| if (!(err instanceof Error)) { | ||
| if (utils.isPlainObject(err)) { | ||
| // This will allow us to group events based on top-level keys | ||
| // which is much better than creating new group when any key/value change |
There was a problem hiding this comment.
Damn, that's a great idea.
There was a problem hiding this comment.
ah, that's awesome kamil. do they need to be hashed? I guess it's a length thing, right?
There was a problem hiding this comment.
Without hashing, very large objects will create way too large fingerprints. This way it's always fixed length as you mentioned.
benvinegar
reviewed
Jan 11, 2018
lib/client.js
Outdated
| // This will allow us to group events based on top-level keys | ||
| // which is much better than creating new group when any key/value change | ||
| var hash = md5(Object.keys(err).sort()); | ||
| var message = 'Sentry: non-Error exception captured [' + hash + ']'; |
There was a problem hiding this comment.
I don't know that we need to prefix Sentry: here.
What about:
Non-Error exception captured with keys foo, bar, ...
^Something like that, only showing the first 2 or 3 keys. That'll be more grokkable than the fingerprint.
HazAT
approved these changes
Jan 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt to tackle #316 and #187