Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Fix reporting fatal errors #425

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

dustinblackman
Copy link
Contributor

@dustinblackman dustinblackman commented Feb 8, 2018

Overview

I have an application in production I noticed was crashing, but never saw any fatal errors sitting in sentry. After digging deeper I found the uncaughtException handler doesn't pass a level, so it defaults to Error. This PR fixes that.

Repro

const raven = require('raven');

const sentry_dsn = 'INSERT DSN HERE';
const client = raven.Client(sentry_dsn);
client.install();

client.captureException(new Error('This is a regular error'));
throw new Error('This is a fatal error');

console.log('Done'); // Never reached.

Before Fix:

screen shot 2018-02-08 at 11 28 39 am

After Fix:

screen shot 2018-02-08 at 11 19 22 am

@kamilogorek
Copy link
Contributor

Thanks @dustinblackman!

@kamilogorek kamilogorek merged commit 4c072ad into getsentry:master Feb 9, 2018
@kamilogorek
Copy link
Contributor

Released as 2.4.1

@dustinblackman dustinblackman deleted the fix-fatal-reporting branch February 9, 2018 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants