Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

docs: Update README #438

Closed
wants to merge 1 commit into from
Closed

docs: Update README #438

wants to merge 1 commit into from

Conversation

WanLinLin
Copy link
Contributor

Add the Node version 8.0.0 prerequisite.

@kamilogorek
Copy link
Contributor

kamilogorek commented Mar 12, 2018

Hey, I'm happy to add this note, however, I'd need you to ask two things if I may.

a) Move it to more appropriate place - https://github.com/getsentry/raven-node/blob/master/docs/usage.rst#contextwrap at the very bottom of context/wrap section

b) Domains are supported since 0.x. Domains for promises are what's supported since 8.x and they are only used to enhance the context for the current domain. If they're not supported, it'll just be skipped and will use globally set context data. What it means, is that context for regular context/wrap and instrumentation is working prior to 8.x just fine. It's just about the promises.

@WanLinLin
Copy link
Contributor Author

Sorry, I didn't express it well. Updated usage.rst is committed.

@kamilogorek
Copy link
Contributor

Slightly reworded and merged manually. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants