Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

fix: Remove a redundant try-catch block #445

Merged
merged 1 commit into from
Apr 5, 2018
Merged

fix: Remove a redundant try-catch block #445

merged 1 commit into from
Apr 5, 2018

Conversation

evgenius
Copy link
Contributor

@evgenius evgenius commented Apr 4, 2018

new Error(message) creates a stack trace. There's no need to throw and catch it.

@kamilogorek
Copy link
Contributor

Nice catch (pun intended)! :D

Tested on:

Node v9
screen shot 2018-04-05 at 14 47 48

Node v4
screen shot 2018-04-05 at 14 48 23

Node v0.12 (just because, we don't support it anyway)
screen shot 2018-04-05 at 14 51 08

@kamilogorek kamilogorek merged commit 354c7cd into getsentry:master Apr 5, 2018
@evgenius evgenius deleted the remove-rendundant-try-catch branch April 5, 2018 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants