Skip to content

Commit

Permalink
minor fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Dav1dde committed Nov 2, 2023
1 parent b8e5fae commit 28e591e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
6 changes: 3 additions & 3 deletions relay-metrics/src/view.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use std::ops::Range;
use crate::bucket::Bucket;
use crate::BucketValue;

/// The fraction of [`AggregatorServiceConfig::max_flush_bytes`] at which buckets will be split. A value of
/// The fraction of [`crate::AggregatorServiceConfig::max_flush_bytes`] at which buckets will be split. A value of
/// `2` means that all buckets smaller than half of max_flush_bytes will be moved in their entirety,
/// and buckets larger will be split up.
const BUCKET_SPLIT_FACTOR: usize = 32;
Expand All @@ -32,7 +32,7 @@ struct Index {
/// A view into a slice of metric buckets.
///
/// The view can be used to iterate over a large slice
/// of metric data slicing even into the buckets themselfs.
/// of metric data slicing even into the buckets themselves.
///
/// ```txt
/// Full View
Expand Down Expand Up @@ -197,7 +197,7 @@ impl<'a> Iterator for BucketsViewBySizeIter<'a> {
}

// Select next potential bucket,
// this won't overflow because `end` will never go past the slice and,
// this won't overflow because `end` will never go past the slice and
// we just validated that current is constrained by end.
let bucket = &self.inner[self.current.slice];
let bucket = BucketView::new(bucket).select(self.current.bucket..bucket.value.len());
Expand Down
2 changes: 1 addition & 1 deletion relay-server/src/actors/envelopes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ impl EnvelopeManagerService {
});
}

while let Some(_) = futures.next().await {}
while futures.next().await.is_some() {}
}

async fn handle_send_client_reports(&self, message: SendClientReports) {
Expand Down
3 changes: 1 addition & 2 deletions relay-server/src/actors/project.rs
Original file line number Diff line number Diff line change
Expand Up @@ -595,8 +595,7 @@ impl Project {
MetricNamespace::Sessions => true,
MetricNamespace::Transactions => true,
MetricNamespace::Spans => state.has_feature(Feature::SpanMetricsExtraction),
// TODO MetricNamespace::Custom => state.has_feature(Feature::CustomMetrics),
MetricNamespace::Custom => true,
MetricNamespace::Custom => state.has_feature(Feature::CustomMetrics),
MetricNamespace::Unsupported => false,
};

Expand Down

0 comments on commit 28e591e

Please sign in to comment.