Skip to content

Commit

Permalink
build(py): Update to python 3.9 (#2876)
Browse files Browse the repository at this point in the history
Adds a `.python-version` file which ensures local virtual envs use the
version corresponding to Sentry. Updates all CI jobs and `setup.py` to
require at least python 3.9.
  • Loading branch information
jan-auer authored Dec 20, 2023
1 parent 3662370 commit 4b42cbd
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build_library.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
- uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: 3.9

- name: Build Wheel
run: |
Expand All @@ -96,7 +96,7 @@ jobs:

- uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: 3.9

- name: Build sdist
run: python setup.py sdist --format=zip
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:

- uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: 3.9

- name: Install Rust Toolchain
run: rustup toolchain install stable --profile minimal --component clippy rustfmt rust-docs --no-self-update
Expand Down Expand Up @@ -144,7 +144,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.8]
python-version: [3.9]

# Skip redundant checks for binary releases
if: "!startsWith(github.ref, 'refs/heads/release/')"
Expand Down Expand Up @@ -387,7 +387,7 @@ jobs:

- uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: 3.9

- run: make test-integration
env:
Expand Down Expand Up @@ -426,7 +426,7 @@ jobs:
with:
workdir: sentry
cache-files-hash: ${{ hashFiles('sentry/requirements**.txt') }}
python-version: 3.8
python-version: 3.9
snuba: true
kafka: true
symbolicator: true
Expand Down
1 change: 1 addition & 0 deletions .python-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.9.18
4 changes: 4 additions & 0 deletions py/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Unreleased

This release requires Python 3.9 or later. There are no intentionally breaking changes included in this release, but we stopped testing against Python 3.8.

## 0.8.39

- Add `_metrics_summary` as temporary key on `Event` for a DDM experiment. ([#2757](https://github.com/getsentry/relay/pull/2757))
Expand Down
2 changes: 1 addition & 1 deletion py/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def find_dylib():
package_data={"sentry_relay": ["py.typed", "_lowlevel.pyi"]},
zip_safe=False,
platforms="any",
python_requires=">=3.8",
python_requires=">=3.9",
install_requires=["milksnake>=0.1.6"],
setup_requires=["milksnake>=0.1.6"],
milksnake_tasks=[build_native],
Expand Down

0 comments on commit 4b42cbd

Please sign in to comment.