Skip to content

Commit

Permalink
feat(spans): Index segments for all organizations (#2659)
Browse files Browse the repository at this point in the history
We need segment information in the spans dataset to power the web
services module for Starfish. This PR will start indexing segments for
all organizations.

---------

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
  • Loading branch information
phacops and jjbayer authored Oct 30, 2023
1 parent 7946f93 commit 939dab7
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 12 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Add inbound filters option to filter legacy Edge browsers (i.e. versions 12-18 ) ([#2650](https://github.com/getsentry/relay/pull/2650))
- Group resource spans by scrubbed domain and filename. ([#2654](https://github.com/getsentry/relay/pull/2654))
- Convert transactions to spans for all organizations. ([#2659](https://github.com/getsentry/relay/pull/2659))
- Filter outliers (>180s) for mobile measurements. ([#2649](https://github.com/getsentry/relay/pull/2649))
- Allow access to more context fields in dynamic sampling and metric extraction. ([#2607](https://github.com/getsentry/relay/pull/2607), [#2640](https://github.com/getsentry/relay/pull/2640))

Expand Down
22 changes: 10 additions & 12 deletions relay-server/src/actors/processor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2366,18 +2366,16 @@ impl EnvelopeProcessorService {
}
}

if all_modules_enabled {
// Extract tags to add to this span as well
let shared_tags = span::tag_extraction::extract_shared_tags(event);
transaction_span.sentry_tags = Annotated::new(
shared_tags
.clone()
.into_iter()
.map(|(k, v)| (k.sentry_tag_key().to_owned(), Annotated::new(v)))
.collect(),
);
add_span(transaction_span.into());
}
// Extract tags to add to this span as well
let shared_tags = span::tag_extraction::extract_shared_tags(event);
transaction_span.sentry_tags = Annotated::new(
shared_tags
.clone()
.into_iter()
.map(|(k, v)| (k.sentry_tag_key().to_owned(), Annotated::new(v)))
.collect(),
);
add_span(transaction_span.into());
}

/// Helper for [`Self::extract_spans`].
Expand Down

0 comments on commit 939dab7

Please sign in to comment.