Skip to content

Commit

Permalink
fix(pii): Remove excessive logging (#2678)
Browse files Browse the repository at this point in the history
The logging introduced with #2670 is too excessive, remove it again.
  • Loading branch information
Dav1dde authored Oct 31, 2023
1 parent 55d7392 commit 95e1b89
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions relay-pii/src/convert.rs
Original file line number Diff line number Diff line change
Expand Up @@ -145,16 +145,10 @@ pub fn to_pii_config(

let spec = match field.parse() {
Ok(spec) => spec,
Err(error) => {
// Invalid safe fields should be caught by sentry-side validation.
// Log an error if they are not.
relay_log::error!(
error = &error as &dyn std::error::Error,
field = field,
"Error parsing safe field into selector",
);

// Fallback to stay compatible with already existing keys.
Err(_) => {
// Ideally safe fields should be caught by sentry-side validation,
// but there is still a considerable amount of "invalid" safe fields.
// Fallback to stay compatible with the old behaviour.
SelectorSpec::Path(vec![SelectorPathItem::Key(field.to_owned())])
}
};
Expand Down

0 comments on commit 95e1b89

Please sign in to comment.