Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mitsuhiko committed Nov 23, 2023
1 parent 219c4eb commit f63fb63
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

**Internal**:

- Add stub metric summaries. ([#2757](https://github.com/getsentry/relay/pull/2757))

## 23.11.1

**Features**:
Expand All @@ -18,7 +24,6 @@
- Support comparison operators (`>`, `>=`, `<`, `<=`) for strings in dynamic sampling and metric extraction rules. Previously, these comparisons were only possible on numbers. ([#2730](https://github.com/getsentry/relay/pull/2730))
- Postpone processing till the global config is available. ([#2697](https://github.com/getsentry/relay/pull/2697))
- Skip running `NormalizeProcessor` on renormalization. ([#2744](https://github.com/getsentry/relay/pull/2744))
- Add stub metric summaries. ([#2757](https://github.com/getsentry/relay/pull/2757))

## 23.11.0

Expand Down
2 changes: 1 addition & 1 deletion relay-event-schema/src/protocol/event.rs
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ pub struct Event {
/// This shall move to a stable location once we have stabilized the
/// interface. This is intentionally not typed today.
#[metastructure(omit_from_schema)]
pub _metrics_summary: Annotated<Object<Value>>,
pub _metrics_summary: Annotated<Value>,

/// Additional arbitrary fields for forwards compatibility.
#[metastructure(additional_properties, pii = "true")]
Expand Down
6 changes: 0 additions & 6 deletions relay-event-schema/src/protocol/span.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,6 @@ pub struct Span {
/// Timestamp when the span has been received by Sentry.
pub received: Annotated<Timestamp>,

/// Temporary protocol support for metric summaries.
///
/// This shall move to a stable location once we have stabilized the
/// interface. This is intentionally not typed today.
pub _metrics_summary: Annotated<Object<Value>>,

// TODO remove retain when the api stabilizes
/// Additional arbitrary fields for forwards compatibility.
#[metastructure(additional_properties, retain = "true", pii = "maybe")]
Expand Down

0 comments on commit f63fb63

Please sign in to comment.