tor review changes

getsentry · Nov 17, 2023 · f7d7690 · f7d7690
1 parent b08d27b
commit f7d7690
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/relay-metrics/src/aggregator.rs b/relay-metrics/src/aggregator.rs
@@ -96,6 +96,10 @@ impl BucketKey {
     }
 }
 
+/// Pendant to [`BucketKey`] for referenced data, not owned data.
+///
+/// This makes it possible to compute a hash for a [`Bucket`]
+/// without destructing the bucket into a [`BucketKey`].
 #[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)]
 struct BucketKeyRef<'a> {
     project_key: ProjectKey,
@@ -540,7 +544,7 @@ impl Aggregator {
             aggregator = &self.name,
         );
 
-        let mut buckets = HashMap::<ProjectKey, Vec<_>>::new();
+        let mut buckets = HashMap::new();
         let mut stats = HashMap::new();
 
         relay_statsd::metric!(
@@ -570,7 +574,10 @@ impl Aggregator {
                             tags: key.tags.clone(),
                         };
 
-                        buckets.entry(key.project_key).or_default().push(bucket);
+                        buckets
+                            .entry(key.project_key)
+                            .or_insert_with(Vec::new)
+                            .push(bucket);
 
                         false
                     } else {

diff --git a/relay-server/src/actors/processor.rs b/relay-server/src/actors/processor.rs
@@ -486,7 +486,7 @@ impl EncodeEnvelope {
     }
 }
 
-/// Encodes metrics into an envelop ready to be sent upstream.
+/// Encodes metrics into an envelope ready to be sent upstream.
 #[derive(Debug)]
 pub struct EncodeMetrics {
     /// The metric buckets to encode.