Switch from global service registry to dependency "injection"

[olksdr]

Currently we use a global registry

relay/relay-server/src/service.rs

Line 35 in 861966f

pub static REGISTRY: OnceBox<Registry> = OnceBox::new();

with all the services having a record there.

This introduces few challenges:

• it's kind of difficult to test separate parts of the services when they are depend on each other
• it's not possible to predict the oder in which services are shutting down, and we might be losing some data

Subtasks

Preview Give feedback

1. Fix tests depending on broken SystemRegistry behavior #1610
   0 of 1
   
2. Log outcomes for dropped metrics buckets #1711
   maintenance
   
3. Metrics aggregator dropping buckets #1629
   bug +1
4. Fix broken shutdown test #1608

As an example how this could look like you can refer to #1770, which introduces also a small isolated test for only 1 service. This will have to be changed for all services:

PRs

Preview Give feedback

1. test(project_upstream): Test correct message handling #1770
   
2. ref: Inject services in project cache and project upstream #1926
   
3. ref(outcomes): Do not use registry in outcome producer #1927
   
4. ref(project): Inject services into the Project #1928
   
5. ref(relay_cache): Inject upstream realy into the service #1932
   
6. ref(processor) Inject dependencies into envelope processor service #1946
   
7. ref(utils): Remove from_registry from utils #1947
   
8. ref(envelope_manager): Remove from_registry calls from the service #1956
   

[olksdr]

At this point we still have few things left where the global registry is used.

Here is the quick grep:

relay-server/src/utils/managed_envelope.rs
191:        let outcome_aggregator = TrackOutcome::from_registry();

relay-server/src/endpoints/public_keys.rs
12:    let relay_cache = RelayCache::from_registry();

relay-server/src/endpoints/outcomes.rs
13:    let producer = OutcomeProducer::from_registry();

and

relay-server/src/actors/envelopes.rs
110:                        ProjectCache::from_registry().send(UpdateRateLimits::new(

relay-server/src/endpoints/common.rs
289:        EnvelopeProcessor::from_registry().send(ProcessMetrics {
309:        ProjectCache::from_registry().send(ValidateEnvelope::new(event_context));
318:        ProjectCache::from_registry().send(ValidateEnvelope::new(managed_envelope));

relay-server/src/endpoints/health_check.rs
16:    Ok(match HealthCheck::from_registry().send(message).await {

relay-server/src/endpoints/forward.rs
243:    UpstreamRelay::from_registry().send(SendRequest(ForwardRequest {

relay-server/src/utils/managed_envelope.rs
257:        TestStore::from_registry().send(Capture::rejected(self.envelope.event_id(), &outcome));

Which are mostly endpoints and utils/managed_envelope.rs which in few cases is also used in the endpoints.

This is basically a followup for #1938. Once the migration to axum is done we can remove the rest of the global registry access and we might also remove global registry all together.