Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timestamp from Metric partition key #3010

Closed
Tracked by #2717
Dav1dde opened this issue Jan 26, 2024 · 0 comments · Fixed by #3025
Closed
Tracked by #2717

Remove timestamp from Metric partition key #3010

Dav1dde opened this issue Jan 26, 2024 · 0 comments · Fixed by #3025
Assignees

Comments

@Dav1dde
Copy link
Member

Dav1dde commented Jan 26, 2024

Having the timestamp included in the metric partition key hurts the performance of the cardinality limiter. While for aggregation we are only interested in a single bucket, the cardinality limiter is interested in the same metric over a long period of time.

Removing the timestamp from the partition key will (greatly) improve the performance of the in memory cardinality cache by consistently routing unique metrics to the same Relay instance hitting the already populated cache.

@Dav1dde Dav1dde self-assigned this Jan 30, 2024
Dav1dde added a commit that referenced this issue Jan 31, 2024
…ching (#3025)

Removes timestamp from partition key, to increase cardinality cache
efficiency.

Closes: #3010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant