Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RELEASE SAVEPOINT and ROLLBACK TO SAVEPOINT SQL statements aren't scrubbed #3085

Closed
Dav1dde opened this issue Feb 9, 2024 · 0 comments · Fixed by #3091
Closed

RELEASE SAVEPOINT and ROLLBACK TO SAVEPOINT SQL statements aren't scrubbed #3085

Dav1dde opened this issue Feb 9, 2024 · 0 comments · Fixed by #3091
Assignees
@jjbayer

Comments

@Dav1dde
Copy link
Member

Dav1dde commented Feb 9, 2024 •
edited
Loading

The sqlparser upgrade broke the scrubbing of RELEASE SAVEPOINT and ROLLBACK TO SAVEPOINT SQL statements. Though even on the old versions those statements had some scrubbing issues.

See also: #3084

Savepoint queries were disabled in #3083 as a quick fix.
@jjbayer jjbayer mentioned this issue Feb 12, 2024
Merged
jjbayer added a commit that referenced this issue Feb 13, 2024
@jjbayer
fix(spans): Scrub RELEASE SAVEPOINT statements (#3091)
7069adc 
sqlparser improved parsing capabilities, which made us rely on the
fallback scrubber less. Unfortunately, In the case of savepoints, the
fallback scrubber caught more than the parser-based scrubber.

Reverts #3083
Fixes #3085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjbayer jjbayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(spans): Scrub RELEASE SAVEPOINT statements getsentry/relay
2 participants
@Dav1dde @jjbayer