New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit negative outcomes when metrics are dropped because of invalid namespace #3532

Closed

iambriccardo opened this issue May 3, 2024 · 1 comment · Fixed by #3544

Assignees

Member

iambriccardo commented May 3, 2024 •

edited

Loading

We would like to emit negative outcomes when metrics are dropped because of invalid namespace, which happens here:

relay/relay-server/src/services/project.rs

Line 592 in 6fed2a7

    
           relay_log::trace!(mri = &*bucket.name, "dropping metric in disabled namespace");

iambriccardo self-assigned this

Member Author

iambriccardo commented May 6, 2024

Consider also comments left at the end of the PR: https://github.com/getsentry/relay/pull/3508/files/a0e40303e91a8c2b52c2e486c558b27efb7c63ca..54b7a32038fd11357ec2d0bdc7f81e175bd20a3c#diff-7e5253bf39a2a49ffeff933e1f36f7d3234f2ba7e00d11ee1e7bc69f9e4e13c7

iambriccardo mentioned this issue

feat(metrics): Emit negative outcomes when namespaces are disabled #3544

Merged

iambriccardo closed this as completed in #3544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment