feat(metrics): Emit negative outcomes when namespaces are disabled #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
commented
May 6, 2024
| @@ -710,7 +725,7 @@ impl Project { | |||
|
|
|||
| match &mut self.state { | |||
| State::Cached(state) => { | |||
| let state = state.clone(); | |||
| let state = Arc::clone(state); | |||
There was a problem hiding this comment.
Change due to a suggestion in a previous related PR: https://github.com/getsentry/relay/pull/3508/files
iambriccardo
commented
May 7, 2024
| if let Some(scoping) = scoping { | ||
| if let Some(scoping) = self.scoping() { | ||
| if !disabled_namespace_buckets.is_empty() { | ||
| utils::reject_metrics( |
There was a problem hiding this comment.
Here i was torn between allowing multiple outcomes to be supported in reject_metrics but I feel like this implementation is a bit more explicit even though it's more verbose.
Dav1dde
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements negative outcomes for metrics that are rejected due to disabled namespace.
Closes: #3532