ref(server): Remove project actors #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
Jun 21, 2021
jjbayer
approved these changes
Jun 21, 2021
jan-auer
reviewed
Jun 25, 2021
fix getting project in UpdateProjectState
jan-auer
approved these changes
Jun 29, 2021
| @@ -193,6 +155,11 @@ pub struct FetchProjectState { | |||
| pub no_cache: bool, | |||
| } | |||
|
|
|||
| impl Message for FetchProjectState { | |||
| type Result = Result<ProjectStateResponse, ()>; | |||
There was a problem hiding this comment.
It's a pretty redundant type, but there's not a lot of use in either keeping nor removing it.
jan-auer
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the ProjectCache - Project actors.
Project is now a simple structure (no more actor functionality) and ProjectCache is responsible
with handling all the messages that Project used to resolve.