feat(filter): Add sampling based on transaction name #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Aug 23, 2021
relay-sampling/src/lib.rs
Outdated
| @@ -365,6 +365,10 @@ impl FieldValueProvider for Event { | |||
| Value::Bool(relay_filter::browser_extensions::matches(self)) | |||
| } | |||
| "event.web_crawlers" => Value::Bool(relay_filter::web_crawlers::matches(self)), | |||
| "event.transaction" => match self.transaction.0 { | |||
There was a problem hiding this comment.
I don't understand why you are doing those conversions, you can use the methods provided by the ToValue trait for this.
There was a problem hiding this comment.
IntoValue converts into our relay_general::Value type , this is a serde_json::Value ... are you suggesting using the realy_geneeral::Value type ?
There was a problem hiding this comment.
IntoValue::??? and then Into::into to get from our Value to serde's Value... duked out IRL, your way is more readable albeit verbose
untitaker
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to sample events & transactions based on the transaction name.
This is supported for both event content and trace content.
This PR introduces another optional field in the trace context (
transaction_name).INGEST-266, INGEST-267, INGEST-268