Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): Use correct argument name for port #1059

Merged
merged 3 commits into from
Aug 23, 2021
Merged

fix(config): Use correct argument name for port #1059

merged 3 commits into from
Aug 23, 2021

Conversation

Michcioperz
Copy link
Contributor

@Michcioperz Michcioperz commented Aug 20, 2021 •
edited
Loading

Also bump onpremise integration tests timeout up to 10 minutes, because they have some nasty variance.

@Michcioperz Michcioperz requested a review from a team August 20, 2021 13:32
jjbayer
jjbayer approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both versions locally 👍

@Michcioperz Michcioperz merged commit 742b9c2 into master Aug 23, 2021
@Michcioperz Michcioperz deleted the fix/port-cli-arg-typo branch August 23, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michcioperz @jjbayer