fix(metrics): Add session.status tag to session.duration #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Sep 22, 2021
jjbayer
commented
Sep 22, 2021
| @@ -551,7 +551,7 @@ fn extract_session_metrics(session: &SessionUpdate, target: &mut Vec<Metric>) { | |||
| unit: MetricUnit::Duration(DurationPrecision::Second), | |||
| value: MetricValue::Distribution(duration), | |||
| timestamp, | |||
| tags, | |||
| tags: with_tag(&tags, "session.status", session.status), | |||
There was a problem hiding this comment.
@jan-auer Do you remember if there was any particular reason we did not add this in the first place? session.duration can definitely be grouped by session.status in sessions_v2.
There was a problem hiding this comment.
I do not remember a particular reason. Only argument that comes to mind now is that it increases size and cardinality of the histogram metric.
jan-auer
approved these changes
Sep 24, 2021
| @@ -551,7 +551,7 @@ fn extract_session_metrics(session: &SessionUpdate, target: &mut Vec<Metric>) { | |||
| unit: MetricUnit::Duration(DurationPrecision::Second), | |||
| value: MetricValue::Distribution(duration), | |||
| timestamp, | |||
| tags, | |||
| tags: with_tag(&tags, "session.status", session.status), | |||
There was a problem hiding this comment.
I do not remember a particular reason. Only argument that comes to mind now is that it increases size and cardinality of the histogram metric.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In session metric extraction, add the session status as a tag to the
session.durationmetric, such that we can group by status in release health.