fix(server): Skip invalid project keys in batch request [INGEST-406] #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Sep 28, 2021
untitaker
reviewed
Sep 28, 2021
| mini_sentry.add_basic_project_config(42) | ||
| public_key = mini_sentry.get_dsn_public_key(42) | ||
|
|
||
| body = json.dumps({"public_keys": ["broken", public_key]}) |
There was a problem hiding this comment.
should parametrize over all values that we discussed in FMEA
There was a problem hiding this comment.
thanks. Added everything except:
- encoding, which we ruled out as a non issue
- large strings, as this is handled by store body as an independent concern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of failing a project config batch request during deserialization, skip invalid keys and serve valid ones. The downstream Relay assumes missing responses as
ProjectState::missing. This is done here by creating aNoneentry, and then setting it to missing here.