Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Limit decompression of UE4 crashes [INGEST-565] #1121

Merged
merged 4 commits into from
Nov 11, 2021

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Nov 11, 2021

Applies the maximum Envelope size to limit decompression of UE4 crash archives. This a potential unbounded buffer allocation during decompression.

Ref getsentry/symbolic#447

@jan-auer jan-auer requested a review from a team November 11, 2021 12:02
relay-server/src/utils/unreal.rs Show resolved Hide resolved
@jan-auer jan-auer merged commit f17070c into master Nov 11, 2021
@jan-auer jan-auer deleted the build/symbolic-8.4.0 branch November 11, 2021 12:58
@jan-auer jan-auer changed the title fix: Limit decompression of UE4 crashes fix: Limit decompression of UE4 crashes [INGEST-565] Nov 11, 2021
@github-actions
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.
Instructions and example for changelog

For changes exposed to the Python package, please add an entry to py/CHANGELOG.md. This includes, but is not limited to event normalization, PII scrubbing, and the protocol.

For changes to the Relay server, please add an entry to CHANGELOG.md under the following heading:

  1. Features: For new user-visible functionality.
  2. Bug Fixes: For user-visible bug fixes.
  3. Internal: For features and bug fixes in internal operation, especially processing mode.

To the changelog entry, please add a link to this PR (consider a more descriptive message):

- Limit decompression of UE4 crashes [INGEST-565]. ([#1121](https://github.com/getsentry/relay/pull/1121))

If none of the above apply, you can opt out by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against b1f93c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants