fix(pii): Ignore replacement_chunks when they aren't used [INGEST-109]
#1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With ReplaceBehavior::Value, we only want to replace a string value. This means we don't need the replacement chunks since `insert_replacement_chunks` correctly adds the replacement and the `process_text` function is useless because we don't need it (besides, processing an empty string doesn't perform any action). Now that the `replacement_chunks` are only needed in ReplaceBehavior::Groups, we can move the processing and assertion we do on them to that branch of the `match`. This solves the issue of asserting on them when we don't use them.
iker-barriocanal
force-pushed
the
iker/fix/pii-proc-replchunks
branch
from
a52a44d to
729be4d
Compare
untitaker
reviewed
Feb 14, 2022
untitaker
approved these changes
Feb 14, 2022
jjbayer
reviewed
Feb 15, 2022
jjbayer
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ReplaceBehavior::Value, we only want to replace a string value.
This means we don't need the replacement chunks since
insert_replacement_chunkscorrectly adds the replacement and theprocess_textfunction is useless because we don't need it (besides,processing an empty string doesn't perform any action).
Now that the
replacement_chunksare only needed inReplaceBehavior::Groups, we can move the processing and assertion we do
on them to that branch of the
match. This solves the issue ofasserting on them when we don't use them.
Fixes #1095.