feat(metrics): Always extract distinct_id [INGEST-1330] #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
approved these changes
May 19, 2022
CHANGELOG.md
Outdated
| @@ -6,6 +6,10 @@ | |||
|
|
|||
| **Features**: | |||
|
|
|||
| - Session metrics extraction: Always extract distinct_id. ([#1275](https://github.com/getsentry/relay/pull/1275)) | |||
There was a problem hiding this comment.
Would classify this under bug fixes and describe what the user-visible effect of this is, or rather what the bug was.
Co-authored-by: Jan Michael Auer <mail@jauer.org>
jjbayer
added a commit
to getsentry/sentry
that referenced
this pull request
May 23, 2022
The javascript SDK apparently does not always send a session.distinct_id with the initial session update, but only on subsequent updates. To make sure we count those users as well, Relay now extracts them under the tag session.status=ok (See also getsentry/relay#1275). This PR changes existing metrics user queries in one of two ways: Wherever we filtered users by status=init, remove the filter. Wherever we grouped by status to get multiple user counts, change the query to a conditional aggregate (uniqIf), so that we get both the total user count (unfiltered) and the user counts filtered to specific tags.
jjbayer
added a commit
that referenced
this pull request
Jun 23, 2022
Since #1275, we extract user IDs into one or more of init, ok, errored, crashed, abnormal buckets. The latter three are used by the product, but init and ok can be consolidated into a single tag, because the product does not query them explicitily as of getsentry/sentry#34858 and getsentry/sentry#34957. In order to reduce the number of buckets stored in clickhouse, consolidate these tags. Also, stop collecting session.duration for non-healthy sessions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The javascript SDK apparently does not always send a
session.distinct_idwith the initial session update, but only on subsequent updates.To make sure we count those users as well, extract them under the tag
session.status=ok. We will need to update queries in sentry to include these users.